Skip to content

Conversation

@jvanderen1
Copy link

Issue

I think it would be a good idea to start deprecating centuries old terminology that have a negative connotation associated with them.

The only term I could see in this project is "whitelist". A better term for this would be "allowlist", as it has better semantic meaning rather than relying on old metaphors.

Suggestion

It would also be great if we could refactor the master branch into the now de facto main branch.

Remarks

Thanks again for being one of the best frontend communities! ❤️

@jvanderen1 jvanderen1 marked this pull request as ready for review July 17, 2022 19:38
@adamwathan
Copy link
Member

Changed to safelist because that's what we use elsewhere in the project already. Closing this one since it includes unrelated changes.

@adamwathan adamwathan closed this Jul 18, 2022
@jvanderen1
Copy link
Author

jvanderen1 commented Jul 18, 2022

@adamwathan Just a question. When making a change, some of the packages get automatically updated which change some of our test/lint behavior. However, these updates don't fix files already committed to the repo. This breaks existing tests.

Should we not clean those to ensure a passing PR before creating one?

Also, I can update this PR without the linting changes and refractor it to safelist instead. Is that something you're okay with?

@adamwathan
Copy link
Member

Hey, already made the change as mentioned (268ef00) so no PR necessary. Tests seem to be passing on that commit so nothing else required here, thanks.

@jvanderen1
Copy link
Author

jvanderen1 commented Jul 18, 2022

@adamwathan Okay, thanks for the heads up. I was referring to our linting test:

npm run style

This currently throws some errors on master. The unrelated changes were caused by:

npm run style -- --fix

which we're asked to run in the CONTRIBUTING docs.

@jvanderen1 jvanderen1 deleted the jvanderen-refactor-whitelist branch July 18, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants