Skip to content

Test#946

Closed
DanielRuf wants to merge 0 commit intotailwindlabs:masterfrom
DanielRuf:fix/prettier-codestyle
Closed

Test#946
DanielRuf wants to merge 0 commit intotailwindlabs:masterfrom
DanielRuf:fix/prettier-codestyle

Conversation

@DanielRuf
Copy link
Contributor

@DanielRuf DanielRuf commented May 29, 2019

No description provided.

@adamwathan
Copy link
Member

This causes the tests to fail because the function returns undefined now :) I'm not getting any lint warnings with what's in master right now and the CI status looks ok:

image

@adamwathan
Copy link
Member

I fixed the code style in this commit:

5e7c263

This PR breaks Tailwind because of automatic semi-colon insertion, this code:

    return
      postcss([
        postcssNested({
          bubble: ['screen'],
        }),
      ]).process(style, {
        parser: postcssJs,
      }).root.nodes

...will always return undefined because it's evaluated like this:

    return;
      postcss([
        postcssNested({
          bubble: ['screen'],
        }),
      ]).process(style, {
        parser: postcssJs,
      }).root.nodes;

I'm on commit ee42b26 locally and yarn run style reports no errors for me 🤔

@adamwathan
Copy link
Member

Running a new build for the master branch right now:

https://travis-ci.org/tailwindcss/tailwindcss/builds/538930343

@DanielRuf DanielRuf closed this May 29, 2019
@DanielRuf DanielRuf changed the title Fix codestyle error reported by prettier Test May 29, 2019
@DanielRuf DanielRuf deleted the fix/prettier-codestyle branch May 29, 2019 20:23
@adamwathan
Copy link
Member

Not sure, it doesn't fail locally for me. Running yarn run style fails for you?

@DanielRuf
Copy link
Contributor Author

Nevermind, it seems to work now. Not sure if there is some issue between npm and Yarn because the scripts use npm and I run yarn like you do in the CI. Probably something npm related (caches?).

@DanielRuf
Copy link
Contributor Author

At least I had also issues that files could not be resolved. After some retries and clearing the npm cache it magically worked again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants