Skip to content

Add line-height modifier for font-size utilities #9875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamwathan merged 10 commits into from
Nov 22, 2022
Merged

Add line-height modifier for font-size utilities #9875

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
06a0eb1
Add line-height modifier for font-size utilities
adamwathan Oct 21, 2022
984d451
Add test for arbitrary values
adamwathan Oct 21, 2022
af88dcd
Add failing test for non-configured modifier values
adamwathan Oct 21, 2022
1ca5d8e
Add more tests (including failing case)
adamwathan Nov 17, 2022
3d5fcd9
Remove unused code
adamwathan Nov 17, 2022
340eb1a
Add note + failing test
adamwathan Nov 17, 2022
ea1720a
Remove unused code
adamwathan Nov 18, 2022
e973fc7
Fix test
adamwathan Nov 18, 2022
50959e8
Fix test
adamwathan Nov 18, 2022
a518e3a
Update changelog
adamwathan Nov 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test for arbitrary values
  • Loading branch information
@adamwathan
adamwathan committed Nov 19, 2022
commit 984d4519a79774d7bd45146762c003b1855a2edc
9 changes: 9 additions & 0 deletions tests/plugins/fontSize.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,7 @@ test('font-size utilities can include a line-height modifier', () => {
{
raw: html`<div class="text-sm md:text-base">
<div class="text-sm/6 md:text-base/7"></div>
<div class="text-sm/[21px] md:text-base/[33px]"></div>
</div>`,
},
],
Expand All @@ -151,6 +152,10 @@ test('font-size utilities can include a line-height modifier', () => {
font-size: 12px;
line-height: 24px;
}
.text-sm\/\[21px\] {
font-size: 12px;
line-height: 21px;
}
@media (min-width: 768px) {
.md\:text-base {
font-size: 16px;
Expand All @@ -160,6 +165,10 @@ test('font-size utilities can include a line-height modifier', () => {
font-size: 16px;
line-height: 28px;
}
.md\:text-base\/\[33px\] {
font-size: 16px;
line-height: 33px;
}
}
`)
})
Expand Down