Skip to content

Conversation

@AlexVipond
Copy link
Contributor

Fixes #979

@AlexVipond AlexVipond changed the title add hr css Add border-width: 1px for horizontal rules Jun 28, 2019
@adamwathan adamwathan merged commit b87aedb into tailwindlabs:master Jul 10, 2019
@adamwathan
Copy link
Member

Thanks @AlexVipond!

@alexdilley
Copy link

Was the intention to make <hr>s 1px in height? Because a 1px border on all sides makes it 2px tall.

@brunolemos
Copy link

Should probably be border-bottom-width: 1px;.

@adamwathan
Copy link
Member

Yep agree, will fix this for the next patch release. Sorry that it'll be another breaking-ish patch 😩

@AlexVipond
Copy link
Contributor Author

AlexVipond commented Aug 13, 2019

Was the intention to make <hr>s 1px in height? Because a 1px border on all sides makes it 2px tall.

My intention was just to find something that looked like a good default—I was designing in the browser, added the border class, and didn't give much thought to the actual pixel height of the element. Although if you put me on the spot, I probably would've have guessed they were 1px tall 😅

Personally I don't have a strong preference between a 1px or 2px tall default border. Maybe it's time for another @adamwathan twitter poll?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug? Horizontal rules are invisible by default

4 participants