Skip to content

Link can't have link class #1123

Description

@HindiWeb

Version(s) affected

2.8.2

Description

        'default_attributes' => [
            Link::class => [
                'class' => "link",
            ],

this will not work and will give a

link() expects exactly 2 arguments, 1 given

if i use link-1 it works, i tried btn btn-link and it worked

How to reproduce

<?php
namespace App\Services;

use League\CommonMark\Environment\Environment;
use League\CommonMark\Extension\CommonMark\CommonMarkCoreExtension;
use League\CommonMark\Extension\CommonMark\Node\Inline\Image;
use League\CommonMark\Extension\CommonMark\Node\Inline\Link;
use League\CommonMark\Extension\DefaultAttributes\DefaultAttributesExtension;
use League\CommonMark\Extension\GithubFlavoredMarkdownExtension;
use League\CommonMark\MarkdownConverter;

class Md2htmlService
{
    protected MarkdownConverter $converter;

    public function __construct()
    {
        $config = [
            'default_attributes' => [
                Link::class => [
                    'class' => "link", // TODO: issue lives here
                ],
                Image::class => [
                    'loading' => 'lazy',
                ]
            ]
        ];
        $environment = new Environment($config);
        $environment->addExtension(new CommonMarkCoreExtension());
        $environment->addExtension(new GithubFlavoredMarkdownExtension());

        $environment->addExtension(new DefaultAttributesExtension());
        

        $this->converter = new MarkdownConverter($environment);
    }

    public function convert(string $markdown): string
    {
        return $this->converter->convert($markdown)->getContent();
    }
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions