Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: timmywil/jquery-ui
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 303fb3b
Choose a base ref
...
head repository: jquery/jquery-ui
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 2ef5467
Choose a head ref
  • 11 commits
  • 37 files changed
  • 3 contributors

Commits on Feb 18, 2025

  1. Build: Upgrade jtr to 0.2.5

    timmywil authored Feb 18, 2025
    Configuration menu
    Copy the full SHA
    fd7dbcd View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2025

  1. Build: Switch from UglifyJS to SWC minify, make the minified file ES5

    More recent UglifyJS versions have started converting regular functions to arrow
    ones, making ES5 source file migrated to a ES2015+ minified one. We want to
    avoid that even in 1.14.x as long as we keep the source file in ES5.
    
    Closes jquerygh-2335
    Ref mishoo/UglifyJS#5967
    Ref jquery/download.jqueryui.com#629
    mgol authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    302b488 View commit details
    Browse the repository at this point in the history
  2. Build: Update ESLint to v9, migrate to flat config, lint dist files

    Dist files linting is limited to checking if they're proper ES5.
    
    Closes jquerygh-2336
    mgol authored Mar 3, 2025
    Configuration menu
    Copy the full SHA
    1da395d View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2025

  1. Build: Bump the github-actions group with 2 updates

    Bumps the github-actions group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [actions/cache](https://github.com/actions/cache).
    
    Closes jquerygh-2334
    
    Updates `github/codeql-action` from 3.28.8 to 3.28.10
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@dd74661...b56ba49)
    
    Updates `actions/cache` from 4.2.0 to 4.2.2
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@1bd1e32...d4323d4)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Mar 14, 2025
    Configuration menu
    Copy the full SHA
    1749a5f View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2025

  1. Build: Remove an obsolete test/.eslintrc.json file

    The file was erroneously left in during the migration to the flat config.
    
    Closes jquerygh-2340
    Ref jquerygh-2336
    mgol authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    ef28a5f View commit details
    Browse the repository at this point in the history
  2. Spinner: Drop dependency on jQuery Mousewheel

    1. Listen to the native `wheel` event without depending on any wrapper plugins.
    2. Keep listening to the `mousewheel` event for compatibility with projects
       using the jQuery Mousewheel plugin but route it to the `wheel` handler.
    
    Closes jquerygh-2338
    mgol authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    6843ced View commit details
    Browse the repository at this point in the history

Commits on Mar 20, 2025

  1. Spinner: Prevent double mousewheel & wheel event handling

    As of jquerygh-2338, if one has loaded the jQuery MouseWheel plugin, the `mousewheel`
    handler would fire the `wheel` one, but the `wheel` one would also run in
    response to the native `wheel` event, resulting in double the distance handled
    by the spinner. To prevent the issue, only fire the `wheel` handler from inside
    the `mousewheel` on if the event was triggered by jQuery - jQuery will not care
    that the underlying event is `wheel` and will only fire handlers for
    `mousewheel`.
    
    Also, add an iframe test using jQuery MouseWheel to not affect all the other
    tests.
    
    Plus, migrate from `QUnit.reset` to `QUnit.done` (see qunitjs/qunit#354).
    
    Closes jquerygh-2342
    Ref jquerygh-2338
    mgol authored Mar 20, 2025
    Configuration menu
    Copy the full SHA
    44de3d3 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2025

  1. Tabs: Support URL-based credentials

    When credentials are provided directly in the URL, e.g.:
    
        https://username:password@www.example.com/
    
    `location.href` strips out the auth part, but anchor links contain them, making
    our `isLocal` computation broken. This fixes it by only looking at `origin`,
    `pathname` & `search`.
    
    Fixes jquerygh-2213
    Closes jquerygh-2345
    mgol committed Mar 31, 2025
    Configuration menu
    Copy the full SHA
    53129e9 View commit details
    Browse the repository at this point in the history
  2. Tabs: Properly handle decoded/encoded anchor hashes & panel IDs

    Prior to jQuery UI 1.14.1, hashes in anchor hrefs were used directly. In
    jquerygh-2307, that was changed - by decoding - to support more complex IDs, e.g.
    containing emojis which are automatically encoded in `anchor.hash`.
    Unfortunately, that broke cases where the panel ID is decoded as well.
    
    It turns out the spec mandates checking both. In the "scrolling to a fragment"
    section of the HTML spec[^1]. That uses a concept of document's indicated
    part[^2]. Slightly below there's an algorithm to compute the indicated part[^3].
    The interesting parts are steps 4 to 9:
    4. Let potentialIndicatedElement be the result of finding a potential
       indicated element given document and fragment.
    5. If potentialIndicatedElement is not null, then return
       potentialIndicatedElement.
    6. Let fragmentBytes be the result of percent-decoding fragment.
    7. Let decodedFragment be the result of running UTF-8 decode without BOM on
       fragmentBytes.
    8. Set potentialIndicatedElement to the result of finding a potential indicated
       element given document and decodedFragment.
    9. If potentialIndicatedElement is not null, then return
       potentialIndicatedElement.
    
    First, in steps 4-5, the algorithm tries the hash as-is, without decoding. Then,
    if one is not found, the same is attempted with a decoded hash.
    
    This change replicates this logic by first trying the hash as-is and then
    decoding it.
    
    Fixes jquerygh-2344
    Closes jquerygh-2345
    Ref jquerygh-2307
    
    [^1]: https://html.spec.whatwg.org/#scrolling-to-a-fragment
    [^2]: https://html.spec.whatwg.org/#the-indicated-part-of-the-document
    [^3]: https://html.spec.whatwg.org/#select-the-indicated-part
    mgol committed Mar 31, 2025
    Configuration menu
    Copy the full SHA
    89b0eca View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2025

  1. Build: Bump the github-actions group with 3 updates

    Bumps the github-actions group with 3 updates: [github/codeql-action](https://github.com/github/codeql-action), [actions/setup-node](https://github.com/actions/setup-node) and [actions/cache](https://github.com/actions/cache).
    
    Closes jquerygh-2347
    
    Updates `github/codeql-action` from 3.28.10 to 3.28.13
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@b56ba49...1b549b9)
    
    Updates `actions/setup-node` from 4.2.0 to 4.3.0
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@1d0ff46...cdca736)
    
    Updates `actions/cache` from 4.2.2 to 4.2.3
    - [Release notes](https://github.com/actions/cache/releases)
    - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
    - [Commits](actions/cache@d4323d4...5a3ec84)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    - dependency-name: actions/setup-node
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-actions
    - dependency-name: actions/cache
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Apr 1, 2025
    Configuration menu
    Copy the full SHA
    5787a75 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2025

  1. Build: Bump the github-actions group with 2 updates

    Bumps the github-actions group with 2 updates: [github/codeql-action](https://github.com/github/codeql-action) and [actions/setup-node](https://github.com/actions/setup-node).
    
    Closes jquerygh-2350
    
    Updates `github/codeql-action` from 3.28.13 to 3.28.16
    - [Release notes](https://github.com/github/codeql-action/releases)
    - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
    - [Commits](github/codeql-action@1b549b9...28deaed)
    
    Updates `actions/setup-node` from 4.3.0 to 4.4.0
    - [Release notes](https://github.com/actions/setup-node/releases)
    - [Commits](actions/setup-node@cdca736...49933ea)
    
    ---
    updated-dependencies:
    - dependency-name: github/codeql-action
      dependency-version: 3.28.16
      dependency-type: direct:production
      update-type: version-update:semver-patch
      dependency-group: github-actions
    - dependency-name: actions/setup-node
      dependency-version: 4.4.0
      dependency-type: direct:production
      update-type: version-update:semver-minor
      dependency-group: github-actions
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored May 11, 2025
    Configuration menu
    Copy the full SHA
    2ef5467 View commit details
    Browse the repository at this point in the history
Loading