Skip to content

Conversation

@tivac
Copy link
Owner

@tivac tivac commented Jan 10, 2025

Description

Previously we were only doing a simple like-for-like match inside of values-import.js, now it actually parses the values and replaces them using the same logic that the values-replace.js plugin uses.

Motivation and Context

Fixes #1020

How Has This Been Tested?

Added a test, existing tests passing

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have added a changeset for my change.

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2025

⚠️ No Changeset found

Latest commit: 6182205

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for m-css ready!

Name Link
🔨 Latest commit f1c4fb4
🔍 Latest deploy log https://app.netlify.com/sites/m-css/deploys/678182a81f70ed000823ae8f
😎 Deploy Preview https://deploy-preview-1022--m-css.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

tivac added 2 commits January 10, 2025 12:24
Fixes #1020

Previously we were only doing a simple like-for-like match inside of `values-import.js`, now it actually parses the values and replaces them using the same logic that the `values-replace` plugin uses
@tivac tivac merged commit d9db40b into main Jan 10, 2025
8 of 9 checks passed
@tivac tivac deleted the value-expansion-fixes branch January 10, 2025 20:30
@github-actions github-actions bot mentioned this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Namespace value imports aren't resolved in downstream dependencies

2 participants