Skip to content

test: use snapshot-diffs #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 28, 2019
Merged

test: use snapshot-diffs #572

merged 3 commits into from
Mar 28, 2019

Conversation

tivac
Copy link
Owner

@tivac tivac commented Mar 28, 2019

Description

Using snapshot-diffs where possible, also changes the output from test-utils/read-dir.js to look a little cleaner.

Motivation and Context

Tidies up snap files and better verifies that changes actually happened between runs.

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tivac added 3 commits March 28, 2019 00:07
Also restructure how custom snapshot matchers are loaded
... and all the snapshots that use that output
@tivac tivac merged commit 89b0398 into master Mar 28, 2019
@tivac tivac deleted the snapshot-diffs branch March 28, 2019 07:29
@TravisBuddy
Copy link

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 2d3689a0-513b-11e9-977c-5d859f4a0935

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants