Skip to content

Add test for svelte <style> + rollup chunking #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 24, 2019
Merged

Add test for svelte <style> + rollup chunking #639

merged 3 commits into from
Jul 24, 2019

Conversation

tivac
Copy link
Owner

@tivac tivac commented Jul 24, 2019

Description

Just a test and some specimens.

Motivation and Context

I want to be sure it works, and this admittedly simple test seems to show that it does. I think there's still a bug rattling around in there somewhere but this is a start.

How Has This Been Tested?

npm test

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

tivac added 3 commits July 23, 2019 23:57
@tivac
feat(test-utils): Add .toMatchRollupAssetSnapshot
4c36e6a 
Because sometimes we only care about assets. Also cleaned up toMatchRollupCodeSnapshot() a bit as well.
@tivac
test(svelte): make sure <style> works w/ rollup chunking
53a82a7 
It does in this test, but based on stuff I've seen working on the website I'm not convinced that there isn't still a bug.
@tivac
test(svelte): remove a dangling .only I left behind
817ec9e
@tivac tivac self-assigned this Jul 24, 2019
@tivac tivac merged commit 993ebe7 into master Jul 24, 2019
@tivac tivac deleted the svelte-inline-styles branch July 24, 2019 07:06
@TravisBuddy
Copy link

Hey @tivac,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: ac9fc730-ade1-11e9-aa77-bf7f12915990

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tivac tivac

Labels
pkg:svelte
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tivac @TravisBuddy