-
Notifications
You must be signed in to change notification settings - Fork 1k
Step minute issue #149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Yeah... recognized this, too. I'll see if I can spare some time and look into it. |
This is caused by if(adjustSliders !== undefined && adjustSliders === true){
this.hour_slider.slider("option", { min: this._defaults.hourMin, max: this._defaults.hourMax }).slider('value', this.hour);
this.minute_slider.slider("option", { min: this._defaults.minuteMin, max: this._defaults.minuteMax }).slider('value', this.minute);
this.second_slider.slider("option", { min: this._defaults.secondMin, max: this._defaults.secondMax }).slider('value', this.second);
} with the following code inspired by if(adjustSliders !== undefined && adjustSliders === true){
var hourMax = (this._defaults.hourMax - (this._defaults.hourMax % this._defaults.stepHour)).toFixed(0),
minMax = (this._defaults.minuteMax - (this._defaults.minuteMax % this._defaults.stepMinute)).toFixed(0),
secMax = (this._defaults.secondMax - (this._defaults.secondMax % this._defaults.stepSecond)).toFixed(0);
this.hour_slider.slider("option", { min: this._defaults.hourMin, max: hourMax }).slider('value', this.hour);
this.minute_slider.slider("option", { min: this._defaults.minuteMin, max: minMax }).slider('value', this.minute);
this.second_slider.slider("option", { min: this._defaults.secondMin, max: secMax }).slider('value', this.second);
} The code before that probably needs some adjustment as well. |
Fix issue #149, sliders max values should not allow for partial steps
This fix is not a solution. Excuse my bad English. :-P |
If i set the step for the minute slider to 5, maximum value on the slider is 59 while it should be 55. if someone could provide a fix for this issue it would be greatly appreciated.
The text was updated successfully, but these errors were encountered: