Error on Website Examples page (AM/PM 12 hour format example)

[rahuljitendradesai]

Your 2nd example, the one which shows AM/PM isn't displaying the correct 'now' time. It shows me pm instead of am. I'm in India and it's 10:05 am right now, but it shows me 10:05 pm instead.

[kevinivek]

This is happening for me too. For the longest time I thought it was my code, but then I realized that it was happening in the examples. Everytime you choose a time, it makes it PM. If you select any of the hours from 12AM to 11AM, it then changes to the same hour but in PM. I was watching it dynamically, and it instantly changes it to PM in the value of the date, it just doesn't display it in the input box until it gets refreshed somehow, ie opening and closing the calendar again. So in the current version of this plugin, if you use the AM/PM 12 hour format, you cannot input in AM times, only PM times.

[phpjeff]

I was having the same problem. I noticed on lines 44 and 45 of the datetimepicker.js file that the amNames and pmNames arrays were being defined with AM and PM capitalized. I changed those to am and pm and now my times are recognized correctly.

[kevinivek]

That worked perfectly, thanks phpjeff.

[rahuljitendradesai]

Yes, It worked for me as well. Thanks phpjeff.

[santyclaz]

Changing the values in 'amNames' and 'pmNames' arrays to lower-case is not a true fix. If the time format of the datetimepicker is set to have AM/PM be capitalized (hh:mm TT) then you'll have the exact same problem.

The issue lies is in the $.datepicker.parseTime function on the following line (line 973 in the current master branch):
ampm = $.inArray(treg[order.t], o.amNames) !== -1 ? 'AM' : 'PM';

treg[order.t] is whatever gets parsed out of the string in the input box, and o.amNames is just the 'amNames' array. So the logic in the above code is essentially "if the period (am/pm) parsed out of the string exists in the amNames array, then it is AM, otherwise PM."

So the true solution is to either add all acceptable cases into the 'amNames' and 'pmNames' arrays (a, A, am, AM, p, P, pm, PM), or to normalize the comparison by either capitalizing or lower-casing everything before comparison.

Personally I think it's cleanest to just do the latter method, so changing the above line to:
ampm = $.inArray(treg[order.t].toUpperCase(), o.amNames) !== -1 ? 'AM' : 'PM';
and keeping the 'amNames' and 'pmNames' unchanged.

[trentrichardson]

Hey santyclaz, thanks for looking in to this. I agree your preferred solution would be best as well. I will be merging this into the dev branch. Thanks again!