Skip to content

mindatetime/maxdatetime (minute selection) bug #389

@sunghyun66

Description

@sunghyun66

Please excuse my bad English.

If you set minDatetime, 'Minute' slider works incorrect way.

so i changed some code.

jquery-ui-timepicker-addon.js - 650 line
-----------original code--------------
if (this.hour <= this._defaults.hourMin) {
this.hour = this._defaults.hourMin;
this._defaults.minuteMin = minDateTime.getMinutes();
if (this.minute <= this._defaults.minuteMin) {
this.minute = this._defaults.minuteMin;
this._defaults.secondMin = minDateTime.getSeconds();
} else if (this.second <= this._defaults.secondMin){
this.second = this._defaults.secondMin;
this._defaults.millisecMin = minDateTime.getMilliseconds();
} else {
if(this.millisec < this._defaults.millisecMin) {
this.millisec = this._defaults.millisecMin;
}
this._defaults.millisecMin = this.millisecMinOriginal;
}
} else {
this._defaults.minuteMin = this.minuteMinOriginal;
this._defaults.secondMin = this.secondMinOriginal;
this._defaults.millisecMin = this.millisecMinOriginal;
}

-------------changed code-----------------------
if (this.hour <= this._defaults.hourMin) {
this.hour = this._defaults.hourMin;
this._defaults.minuteMin = minDateTime.getMinutes();
if (this.minute <= this._defaults.minuteMin) {
this.minute = this._defaults.minuteMin;
this._defaults.secondMin = minDateTime.getSeconds();
if (this.second <= this._defaults.secondMin){
this.second = this._defaults.secondMin;
this._defaults.millisecMin = minDateTime.getMilliseconds();
}
else {
if(this.millisec < this._defaults.millisecMin) {
this.millisec = this._defaults.millisecMin;
}
this._defaults.millisecMin = this.millisecMinOriginal;
}
}
else{
this._defaults.secondMin = this.secondMinOriginal;
this._defaults.millisecMin = this.millisecMinOriginal;
}
}
else {
this._defaults.minuteMin = this.minuteMinOriginal;
this._defaults.secondMin = this.secondMinOriginal;
this._defaults.millisecMin = this.millisecMinOriginal;
}

I think #378 is same issue.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions