Skip to content

mindatetime/maxdatetime (minute selection) bug #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sunghyun66 opened this issue Jul 13, 2012 · 1 comment
Closed

mindatetime/maxdatetime (minute selection) bug #389

sunghyun66 opened this issue Jul 13, 2012 · 1 comment

Comments

@sunghyun66
Copy link

Please excuse my bad English.

If you set minDatetime, 'Minute' slider works incorrect way.

so i changed some code.

jquery-ui-timepicker-addon.js - 650 line
-----------original code--------------
if (this.hour <= this._defaults.hourMin) {
this.hour = this._defaults.hourMin;
this._defaults.minuteMin = minDateTime.getMinutes();
if (this.minute <= this._defaults.minuteMin) {
this.minute = this._defaults.minuteMin;
this._defaults.secondMin = minDateTime.getSeconds();
} else if (this.second <= this._defaults.secondMin){
this.second = this._defaults.secondMin;
this._defaults.millisecMin = minDateTime.getMilliseconds();
} else {
if(this.millisec < this._defaults.millisecMin) {
this.millisec = this._defaults.millisecMin;
}
this._defaults.millisecMin = this.millisecMinOriginal;
}
} else {
this._defaults.minuteMin = this.minuteMinOriginal;
this._defaults.secondMin = this.secondMinOriginal;
this._defaults.millisecMin = this.millisecMinOriginal;
}

-------------changed code-----------------------
if (this.hour <= this._defaults.hourMin) {
this.hour = this._defaults.hourMin;
this._defaults.minuteMin = minDateTime.getMinutes();
if (this.minute <= this._defaults.minuteMin) {
this.minute = this._defaults.minuteMin;
this._defaults.secondMin = minDateTime.getSeconds();
if (this.second <= this._defaults.secondMin){
this.second = this._defaults.secondMin;
this._defaults.millisecMin = minDateTime.getMilliseconds();
}
else {
if(this.millisec < this._defaults.millisecMin) {
this.millisec = this._defaults.millisecMin;
}
this._defaults.millisecMin = this.millisecMinOriginal;
}
}
else{
this._defaults.secondMin = this.secondMinOriginal;
this._defaults.millisecMin = this.millisecMinOriginal;
}
}
else {
this._defaults.minuteMin = this.minuteMinOriginal;
this._defaults.secondMin = this.secondMinOriginal;
this._defaults.millisecMin = this.millisecMinOriginal;
}

I think #378 is same issue.

@trentrichardson
Copy link
Owner

Thank you, I will review and add it to the dev branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants