"Now" Button returning 'pm' in the 'am', in 12 hour format

[ncramer]

Example:

At 1:40AM click the Now button in example 2 - http://trentrichardson.com/examples/timepicker/
"Show time in AM/PM 12 hour format"
$('#example2').datetimepicker({ampm: true});

Expected result:
07/28/2012 01:40 am
Actual result:
07/28/2012 01:40 pm

Issue:

Default time format for ampm is hh::ss tt (lowercase am/pm)

But, at line 973 we state:
ampm = $.inArray(treg[order.t], o.amNames) !== -1 ? 'AM' : 'PM';

And the default regional codes fo are caps:
amNames: ['AM', 'A'],
pmNames: ['PM', 'P'],

So since 'am' is not in ['AM', 'A'], PM is always returned

At a minimum I would make the defaults consistent. Better, I'd compare in a case-insensitive manner or use the value directly.

[jlbriggs]

The input field is populated with the correct am/pm designation, but the picker itself still displays 'pm' when you use the 'now' option.

[jlbriggs]

I take that back...it does not populate correctly.
Does anyone have a solution to the 'now' button always jumping to PM?
Any help would be appreciated.

[ncramer]

Several different quick solutions that may work and don't require a ton of code review, not familiar enough with the full codebase to confirm there are no unintended consequences:

1. Add 'a', 'am' to amNames and 'p', 'pm' to pmNames?
2. strtoupper treg[order.t] at line 973 so that it will match case w/ the existing default values
   ampm = $.inArray(treg[order.t], o.amNames) !== -1 ? 'AM' : 'PM';
3. In the same line as line above, simply output treg[order.t] instead of doing a comparison and conditionally displaying a static 'AM' or 'PM'.

I don't know that any of these are "right" but hopefully will point you in the right direction.

[jlbriggs]

1. Add 'a', 'am' to amNames and 'p', 'pm' to pmNames?

that worked for me. thanks.