Option getter always returns the source jquery object (1.0.2, 1.0.3, ..., 1.4.4)

[rbeurskens]

When requesting an option that is not 'getDate' , the query object itself is returned instead of the value(s) of the requested option.

suggested fix ( don't know if it is bulletproof ):

$.fn.extend({
    //########################################################################
    // shorthand just to use timepicker..
    //########################################################################
    timepicker: function(o) {
        o = o || {};
        var tmp_args = arguments;

        if (typeof o == 'object') { tmp_args[0] = $.extend(o, { timeOnly: true }); }

        var result = $(this).map(function() {        //  <---
            return /* <---- */ $.fn.datetimepicker.apply($(this), tmp_args); 
        });
        return (result[0]==$(this)[0]) ? result : result[0]; // <---

    },

    //########################################################################
    // extend timepicker to datepicker
    //########################################################################
    datetimepicker: function(o) {
        o = o || {};
        var tmp_args = arguments;

        if (typeof(o) == 'string'){
            if(o == 'getDate' /**/ ||  (o == 'option' && tmp_args.length == 2 && typeof (tmp_args[1]) == 'string')) /*<---*/) {
                return $.fn.datepicker.apply($(this[0]), tmp_args);
            }
            else {
                    return  = this.each(function () { 
                        $(this).datepicker.apply($t, tmp_args);  
                    });
            }
        }
        else {
            return this.each(function() {
                var $t = $(this);
                $t.datepicker($.timepicker._newInst($t, o)._defaults);
            });
        }
    }
});

[rbeurskens]

(issue also confirmed for 1.0.3)

applied a fix to the suggested fix:
return (o == 'option' && tmp_args.length == 2 && typeof (tmp_args[1]) == 'string') ? result : this ;

[rbeurskens]

finally applied a working getter for 'options' (assuming the are no other getters apart from 'getDate')

[rbeurskens]

Still applies to latest (1.4.4). Should I use a pull request? (note: added code is just copy/paste from similar lines in jQuery UI Datepicker widget, which does have a getter for options)

        /*
        * extend timepicker to datepicker
        */
        datetimepicker: function (o) {
            o = o || {};
            var tmp_args = arguments;

            if (typeof(o) === 'string') {
/*--*/          if (o === 'getDate' ) {
/*++*/          if (o === 'getDate'  || (o === 'option' && tmp_args.length === 2 && typeof (tmp_args[1]) === 'string')) {
                    return $.fn.datepicker.apply($(this[0]), tmp_args);
                } else {
                    return this.each(function () {
                        var $t = $(this);
                        $t.datepicker.apply($t, tmp_args);
                    });
                }
            } else {
                return this.each(function () {
                    var $t = $(this);
                    $t.datepicker($.timepicker._newInst($t, o)._defaults);
                });
            }
        }
    });

[trentrichardson]

@rbeurskens thanks for this, sorry it has taken so long, I managed to get buried in requests and issues..

It is in dev now and I want to get a new stable version within the week.