Skip to content

Calendar remians open after date selection when showTimepicker = false #687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
spmorganjr opened this issue Jan 21, 2014 · 1 comment
Closed

Comments

@spmorganjr
Copy link
Contributor

There's an override to the _selectDate() method that prevents the calendar from closing after selecting a new date. If the timepicker is not enabled then there's no reason to execute this code, it should instead fire the base _selectDate() method.

There's a check for the instance of the timepicker tp_inst, however this is always evaluating as true. Should also be checking for showTimepicker option.

@spmorganjr
Copy link
Contributor Author

Resolved with pull request #688.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant