Issue # 687 - Calendar remians open after date selection when showTimepicker = false #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…endar from closing after selecting a new date. If the timepicker is not enabled then there's no reason to execute this code, it should instead fire the base _selectDate() method.
trentrichardson
added a commit
that referenced
this pull request
Jan 27, 2014
Issue # 687 - Calendar remians open after date selection when showTimepicker = false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's an override to the _selectDate() method that prevents the calendar from closing after selecting a new date. If the timepicker is not enabled then there's no reason to execute this code, it should instead fire the base _selectDate() method since the jQuery Datepicker is designed to close upon selection.