parseTime regex fix for special characters #123
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I made a small fix that escapes regex special characters like |()[]+?... in the time separator. It's unlikely that anyone would use any separator other than " " for their time format. But if they do and they use one of the special regex characters, they won't get a "NaN" parse error.
Also, it just happens to make the regex a little simpler by matching from the end of string and ignoring the date portion in the beginning.
Let me know what you think of this patch.
Thanks