fix to min/max minute (and second) values, when selected hour != min hour #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I applied this to the dev branch. Be aware I also noticed the min/maxDateTime options can skew the number grid under the sliders. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows to select all minutes (0 - 59) when currently selected hour is different form minimum/maximum hour specified by min/maxDate settings. It also allows to limit min/maxTime, when using only timepicker().
The bug can be seen on http://trentrichardson.com/examples/timepicker/#example14 , when trying to select '01/20/2011 12:30'.
It is a bug mentioned in issues #75, #109, #110