Classes and styles to reset label tables in the event of global table styles #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you create this pull from the dev branch? then I can automatically merge it. Or I can add it in when i get a chance. |
|
Sorry about that, wasn't thinking how awkward that would be! This one should be good on pull request 191. Ben |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added classes to label tables when hour grid and minute grid are used. I've also added a style to reset the tables, which should help in eliminating any weird global table styling. Without the class, the nearest identifier for both labels is div.ui-timepicker-div>dl>dd>div>table, which is much slower for style parsers to process.
Let me know if you think this is useful or not.