Skip to content

Hi i've made some changes #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Conversation

kuzemchik
Copy link

Allmost about options.
Time disappearing fixed, min max is working now (i've checked twice =) ).
onSelect subscribe is now working for options (i mean slider time changes).

@trentrichardson
Copy link
Owner

I've added in your changes for onSelect, they work beautifully. However I tried this example (from the documentation)

$('#example14').datetimepicker({

    //minDate: new Date(2010, 11, 20, 8, 30),

    maxDate: new Date(2010, 11, 31, 17, 30)

}).datetimepicker('option','minDate',new Date(2010, 11, 20, 8, 30));

and maxDate works as expected, but with minDate only the date is restricted, the time can go below 08:30. I'll go ahead and close this pull since I've added your changes to dev and I'll be merging some other changes as well. (Be sure to fork from the dev branch and issue your pull from that branch as well if you make any further changes). Thanks for all your work!

@kuzemchik
Copy link
Author

I'll try to figure out what's with this example on tomorrow.

@kuzemchik
Copy link
Author

Currently such code works.

$('#example14').datetimepicker({

    //minDate: new Date(2010, 11, 20, 8, 30),

    maxDate: new Date(2010, 11, 31, 17, 30)

}).datetimepicker('option','minDateTime',new Date(2010, 11, 20, 8, 30));

I have some time, so I'll try to find out better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants