beforeShow fix #289
Closed
beforeShow fix #289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tePicker. If the value returned from beforeShow (custom function) is false, popup must not show up. (This is the general behaviour in JQuery UI DatePicker as well.
Owner
|
Thanks for the fix. I added it to the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Trent,
Noticed that even though I have beforeShow event added to my code and while it was returning false, DateTime picker used to popup. Digging into the code, I found that the beforeShow in your plugin did not return the value from event "beforeShow". I have added that just to make sure that beforeShow feature remains intact.
Needless to mention, JQuery UI Datepicker uses beforeShow value to decide whether to show date picker or not.
Thanks!
Kunal