Update of DateTimePicker #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed syntax and coding style to better fit jQuery UI's practices Reformatted line breaks, braces, and spacing for consistency Renamed variables and functions for consistency, using _ to denote private vars/fns Shortened variable declarations whenever possible Improved efficiency of jQuery object calls Now operates on jQuery collections instead of just single elements Fixed incorrect parentheses in new _getDate fn Various bugfixes and cleaning JSLint-verified (braces are unnecessary for single-line statements where a semi-colon is used properly) Provides exact same functionality but is over 2.6K smaller!
|
Hey Charles, Thanks a lot for your work. I made a few changes today to the latest version, were you able to get those as well? Trent |
|
Hi Trent, Yes, my code should be current with your most recent commit. Charles |
|
I tested it against all of my examples and it worked fine. Thanks big time for your work! I committed it, but have not yet updated the documentation with this until it has seen some more testing. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Trent,
Thanks for your hard work creating this addon for jQuery UI's Datepicker. It's been a big help in my current project and I see many uses for it. I have rewritten the Timepicker addon to keep a consistent OO-style that should make it easier to extend the Timepicker as the codebase grows. I also found some places that I was able to increase the efficiency of the code while overall shortening the filesize. I tried to keep the coding style consistent, to match the practices of the jQuery UI Codebase. Therefore I also recommend changing the filename to jquery.ui.timepicker_addon.js to match the jQuery UI naming convention.
Github had a hard time parsing all the changes from the commit, I find it's easier to compare your and my versions side-by-side. The functionality should be exactly the same (or better), but I'm sure it could use a lot more testing. Please let me know if you have any questions.
Cheers,
Charles