Change timezone when date is changed #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Two people, same idea: I just build the same with in #343. |
|
Thanks for all your ongoing help and fixes. Just so I don't mix up changes as there are two working on the same thing at once (not complaining, thats excellent!). Does this still need to be merged? I merged #343 just a moment ago, which apepper mentions fixes the same thing. |
|
kapouer@177fe3a is still valid : i use and expect the timezone to change even in the absence of timezoneSelect. @apepper : i set useLocalTimezone:true but tp_inst.useLocalTimezone stays false (the default value). There is a bug with setting that value. It works all right if i hardcode it. |
|
I'm opening a new pull request to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accounts for daylight savings.