Major bugfix for calling timepicker on a jQuery collection, formatting, + misc #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reuse jQuery obj for buttonPanel var statement consolidation Shortened default option code for $.fn.timepicker()
… jQuery collection Fixed $buttonPanel typo Consolidated .timepicker(), .datetimepicker() fns by using .apply() Fixed == to === when comparing null and undefined in extendRemove fn (thanks JSLint!)
|
I keep getting a this.each is not a function? I think the regional stuff probably works. My only test was to pass in the translations as options and that worked fine. |
|
Fixed it and committed |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Trent,
I see you've caught some of my typos, thanks. This code was rebased from your latest commits.
I fixed some formatting issues with long lines and mixed tabs and spaces. I also made some changes to simplify calling timepicker with different sets of arguments, based off the code that the Datepicker plugin uses. The major change is that a new Timepicker will be created for each input in a jQuery collection, previously I had not written this correctly. To do this a _newInst() fn was created.
I haven't had a chance yet to test the regional settings, do you have any regional-ized testcases I could use for example?
HTH,
Charles