Merging my changes #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Adapted from commit 0cc3c4c by Andrew Montgomery-Hurrell (Github user darkliquid). http://github.com/darkliquid/jQuery-Timepicker-Addon/commit/0cc3c4cc3cc3c28a432b4de69afcbea9ce0b0ec0
* Andrew Montgomery-Hurrell committed 0cc3c4c: "Fixed issue in addTimePicker where \S wasn't matching against the date string properly." http://github.com/darkliquid/jQuery-Timepicker-Addon/commit/0cc3c4cc3cc3c28a432b4de69afcbea9ce0b0ec0
* http://jqueryui.com/docs/Developer_Guide#Coding_Style 1. put comments before the line they describe 2. space after "//" 3. removed "//-------" comments
* Missed two places where Andrew Montgomery-Hurrell (Github user darkliquid) changed a '==' to a '==='. http://github.com/darkliquid/jQuery-Timepicker-Addon/commit/0cc3c4cc3cc3c28a
- improve consistency and readability
- adjust whitespace to improve legibility - prefer // comments over /* */ comments - refactor updateDateTime method to use cleaner logic
Merged from development branch.
|
So, I guess you can close this request, since you already merged the changes another way. Or maybe I can close it...let me try. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Trent,
Wow, this was way easier than I thought it would be. You should be able to merge my changes in by responding to this request. This help page talks about the "pull request" process.
FYI, I'm hoping to continue with some more changes either today or tomorrow. I first want to add accessors. If I get ambitious I might try for a (probably rudimentary) test suite. So, I may send you further pull requests later.
Thanks for your interest,
-Jeff T.