Regional settings fix (solves Issue 32) #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, I merged your fix. Also I noticed a missing option in the regional, which is closeText. This replaces the "Done" button text. It was specified in the datepicker options, however if you're only using timepicker we would need it. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Trent,
I found the bug, I was copying the new instance defaults instead of the global defaults when creating a new Timepicker.
Also, I've created an 'unstable' branch in my repo where code will be in-progress. From now on I will make pull requests properly from the stable master branch without mixing up stable and unstable code.
Cheers,
Charles