fix splitDateTime for plain datepicker #452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using a plain datepicker, getDate returns always the current date because splitDateTime puts the date in the time part of the result. This change only splits when the input actually contains a time.
When the dateFormat contains the separator that is used to split date and time, parseDate fails. Also, since parseDate has no access to the instance, it does not know the correct timeFormat, so splitting is not always correct. Restoring the old hack of relying on datepickers error message seems to fix these issues.
trentrichardson
added a commit
that referenced
this pull request
Sep 20, 2012
fix splitDateTime for plain datepicker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for dev this time, instead of master.
When using a plain datepicker, getDate returns always the current date because splitDateTime puts the date in the time part of the result.
This change only splits when the input actually contains a time.