altField contains only date after init in inline mode (attached to a div) #455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution. Looks like though you sent the pull request to dev (v1.0.4) but your changes were on the master branch (v1.0.3). Would you be willing to apply this same change to dev and issue a pull request? Also, I see your change was to fix for inline, does this have any effect on standard non-inline datetimepickers? |
|
This has been added to dev, Thanks! |
|
Cool! Glad I could help you to fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
At init, in inline mode, the altField only contains the date but not the time.
Going step by step in the code shown me that it's because the "_updateAlternate" method is used by the original datepicker.
I overrided it (another hack...) and added the time. The code is inspired by the _updateDateTime original method.