Remove $.datepicker.log

[nicofrand]

jQuery ui 1.10.0+ does not implement $.datepicker.log anymore.
This replaces all datepicker.log calls by console.log (which is the same thing actually).

[trentrichardson]

Thanks for pointing that out. A couple thoughts. When some browsers don't have the console open they can throw errors to the user (which may not be preferred). Perhaps they should be wrapped with:

if(window.console)
    console.log('error text...');

Just to keep things more DRY maybe we should create a $.timepicker.log() to do this. However I wouldn't mind knowing why datepicker quit with $.datepicker.log(), maybe we need to follow their lead?

Also this pull request was to master, these changes will need to go through the dev branch first.

Trent

[nicofrand]

Datepicker was not testing window.console in their own method, but I
guess that would not be too much.
For the DRY part, this could be useful if, for example, you allowed the
user to report errors in the console or not (that might be really
practical).

I asked on IRC if anyone knew why they did remove it since it is not
mentionned anywhere (upgrade guide, blog post, website) but someone
answered me
that since it was not documented, the method could be removed anytime
they wanted without warnings.

Sorry for the wrong branch, this was my first Git experience…

Nicolas

Le 29/01/2013 20:11, Trent Richardson a écrit :

Thanks for pointing that out. A couple thoughts. When some browsers
don't have the console open they can throw errors to the user (which
may not be preferred). Perhaps they should be wrapped with:

if(window.console)
console.log('error text...');

Just to keep things more DRY maybe we should create a
$.timepicker.log() to do this. However I wouldn't mind knowing why
datepicker quit with $.datepicker.log(), maybe we need to follow their
lead?

Also this pull request was to master, these changes will need to go
through the dev branch first.

Trent

—
Reply to this email directly or view it on GitHub
#543 (comment).

Cordialement,

Frandeboeuf </nicofrand/> Nicolas, http://blog.breizhogeek.com

htt://blog.breizhogeek.com

[trentrichardson]

No problem, I did a quick find replace and did this on the dev branch. Thanks for checking!