Skip to content

Microseconds added to the timepicker #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kasunchathuranga
Copy link
Contributor

This pull request adds support for microseconds to jQuery-timepicker-addon.

phpMyAdmin project uses jQuery-timepicker-addon to edit values for MySQL's time, datetime and timestamp data types. MySQL has recently introduced the ability to have milliseconds and microseconds in the above data types and I am giving a try at upgrading phpMyAdmin code to support this change. While doing that I improved the jQuery-timepicker-addon to support microseconds and I wish to contribute that code back to the jQuery-timepicker-addon project.

I have a small query. If you decide to merge this pull request when will this be a part of a release? I am asking this because phpMyAdmin project prefers to use a released version over a patched one.

@trentrichardson
Copy link
Owner

Hey Kasun, Thanks bigtime for your additions. I won't be able to immediately drop these changes into master, but I do have some changes in dev that will be merging soon. (As in next two weeks I have planned). Hopefully I can incorporate these too. Github is hinting there may be conflicts on merge with my changes so I will try to look through for any issues. Thanks again!

@trentrichardson
Copy link
Owner

Also would like to roll out localizations for this too, I'm sure phpMyAdmin will as well. Please keep timepicker in mind too if possible to update micro second translations too :) An thanks for your work on phpMyAdmin too!

@pierrocknroll
Copy link

I have an error with these changes :
Cannot read property 'millisecMin' of undefined, line 584

I think it's _defaults instead of _default...

@trentrichardson
Copy link
Owner

Thanks for the report, I will try to take a look this week.
On Apr 26, 2013 5:02 AM, "pierrocknroll" notifications@github.com wrote:

I have an error with these changes :
Cannot read property 'millisecMin' of undefined, line 584

I think it's _defaults instead of _defaults...


Reply to this email directly or view it on GitHubhttps://github.com//pull/577#issuecomment-17062519
.

@trentrichardson
Copy link
Owner

Ok, I fixed this and a couple other lines with typos regarding these updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants