Added missing time format parameter in detectSupport call. #601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In detectSupport(), the call to set ampm was missing a parameter. The code has been updated to include the time format string.
trentrichardson
added a commit
that referenced
this pull request
Jul 2, 2013
Owner
|
Thanks for catching that and issuing a pull request. The diff on your pull looked to change a bunch of lines, so I just changed it manually. Your description helped with that, thanks again! Trent |
Author
|
Sorry about that it was my first ever pull request. Glad to hear that you found it still. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In detectSupport(), the call to set ampm was missing a parameter. The
code was been updated to include the time format string to the call for proper initialization.