Dev #618
Merged
Dev #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timezoneOffsetString() tests based on the timezone work. Changed the default timezone to null and eliminated double quotes from the regexp for literals.
…loper who specified whitespace in their format.
…sbeautifier or some formatter to the grunt config so this doesn't have to be done manually.
…e-fixture dependency.
trentrichardson
added a commit
that referenced
this pull request
Jul 29, 2013
Grunt cleanup, lint cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Trent --
In addition to some new tests and fixes, I did a lot of jshint cleanup and fixed the 'grunt jasmine' test failure.
We should consider adding jsbeautifier or something like it to automatically format the files.
I don't yet know how to make jshint know about