Skip to content

Allow to use datepicker specific setDate arguments #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

aokros
Copy link
Contributor

@aokros aokros commented Apr 7, 2014

Change is to support the '-1d', '+1m', and such datepicker.setDate arguments with the overridden setDate function.

Change is to support the '-1d', '+1m', and such datepicker.setDate arguments with the overridden setDate function.
@trentrichardson
Copy link
Owner

Thanks @aokros , would you be able to issue a pull for these changes to the dev branch?

@aokros
Copy link
Contributor Author

aokros commented Apr 7, 2014

I'm on it, but I've got issues with this. This is my first github change I
ever made, so forgive this to me, please. I'm trying to diff the "
trentrichardson:dev ... aokros:master" branches, and it has a lot of other
comments as well. I'm going to cherry-pick my change to my dev branch and
try to create a pull request of it. Is this okay?

On 7 April 2014 15:15, Trent Richardson notifications@github.com wrote:

Thanks @aokros https://github.com/aokros , would you be able to issue a
pull for these changes to the dev branch?

Reply to this email directly or view it on GitHubhttps://github.com//pull/712#issuecomment-39727736
.

@aokros
Copy link
Contributor Author

aokros commented Apr 7, 2014

Done. Sorry for skipping the guidelines!

@trentrichardson
Copy link
Owner

No problem, thanks for your help and contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants