Skip to content

Add altRedirectFocus option #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 12, 2014
Merged

Add altRedirectFocus option #725

merged 4 commits into from
May 12, 2014

Conversation

emlun
Copy link
Contributor

@emlun emlun commented May 11, 2014

If set to true (default), the altField will redirect focus to the main field (this is how it always worked before this change). Otherwise, the altField will not redirect its focus, and the altField will behave as a normal text field that can be edited by the user.

Note that this option is effective only at construction time - changing it on an existing instance will have no effect.

emlun added 4 commits May 11, 2014 23:29
This setting throws an error in JSHint 2.0.0 and above, as explained by
http://jslinterrors.com/es5-option-is-now-set-per-default
If set to true (default), the altField will redirect focus to the main
field (this is how it always worked before this change). Otherwise, the
altField will not redirect its focus, and the altField will behave as a
normal text field that can be edited by the user.
@trentrichardson
Copy link
Owner

Thanks for this, great option. As for the .jshintrc question what you have seems correct by prefixing with jasmine and adding it as a predefined variable in the jshint config:

http://jasmine.github.io/2.0/introduction.html#section-Spies:_createSpy

trentrichardson added a commit that referenced this pull request May 12, 2014
@trentrichardson trentrichardson merged commit e865e72 into trentrichardson:dev May 12, 2014
@emlun emlun deleted the redirect-focus-option branch May 12, 2014 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants