Fix issue with lowercase amNames selector format #779
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lowercase am selector formats are interpreted as PM because of an error in the am selector recognition logic, line 1238, jquery-ui-timepicker-addon.js: Original: ampm = $.inArray(treg[order.t].toUpperCase(), o.amNames) !== -1 ? 'AM' : 'PM'; Proposed: ampm = $.inArray(treg[order.t].toUpperCase(), o.amNames.toUpperCase()) !== -1 ? 'AM' : 'PM'; This bug causes lowercase am selector strings in amNames to be interpreted as PM when parsing the original value, resulting in inadvertent change of, for instance, 10 a.m. to 10 p.m. If the user didn't intend to change the date/time in the first place this is specially damaging because the user can miss the change and commit the form with the wrong time. Also note that amNames[0], which is used when wring back to the field is usually in lowercase. Fix: Using the same transformation (toUpperCase) in both sides preserves the equality.
There was an additional place where am-pm detection logic had de same problem.
This ocurence was not in error. Over-eager search-n-repl.
Basically I was calling toUpperCase on an array instead of mapping and applying to each element.
trentrichardson
added a commit
that referenced
this pull request
Feb 10, 2015
Owner
|
Thanks for the fix. I merged it with the dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lowercase amNames selectors ignored and interpreted as PM because of an error in the am selector recognition logic, line 1238, jquery-ui-timepicker-addon.js
This error causes inadvertent change of, for instance, 10 a.m. to 10 p.m. If the user didn't intend to change the date/time in the first place (just oppened and closed the selector) this error can cause the form to be sent with the wrong time. Also note that amNames[0], which is used when wring back to the field is usually in lowercase for i18n files.
Fix: Using the same transformation (toUpperCase) in both sides preserves the equality.
Original:
Proposed: