Skip to content

Conversation

@kumm
Copy link
Contributor

@kumm kumm commented Jan 23, 2011

The bug affects your example page too.
See:
http://trentrichardson.com/examples/timepicker/
"Default Hours, Minutes, Seconds" section.

@edng
Copy link

edng commented Jan 23, 2011

It's a bug in the hour_slider, minute_slider, second_slider set up. The sliders use default value of the class which are always 0. It's fixed by changing "value: this.hour" to "value: o.hour" on line 345 under "this.hour_slider" set up, "value: this.minute" to "value: o.minute" on line 359 under "this.minute_slider" setup, "value: this.second" to "value: o.second" on line 372 under "this.second_slider" setup. Note that this fix works fine in my specific use. I haven't done extensive test to see if it affects other features.

@kumm
Copy link
Contributor Author

kumm commented Jan 25, 2011

I think it's just a matter of taste. Your solution has to work too.

@midnightmonster
Copy link

I just filed a bug on this issue, but your fix would cause the time to be changed back to the defaults every time the panel is opened, even if I set it to something else in between.

@kumm
Copy link
Contributor Author

kumm commented Feb 6, 2011

midnightmonster: I dont' think so. The '_newInst' function is called only once, at instatiation. Not every time the panel is opened.

@midnightmonster
Copy link

kumm, you're right--I'm new to the pull request interface. I was responding to edng's suggestion (which does have the effect I described), not noticing it was a different person writing, nor that I could see the actual code in the pull request by clicking diff above.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants