Add extra type cast to String before call split()#76
Open
MinhThienDX wants to merge 1 commit intotuupola:2.xfrom
MinhThienDX:2.x
Open
Add extra type cast to String before call split()#76MinhThienDX wants to merge 1 commit intotuupola:2.xfrom MinhThienDX:2.x
MinhThienDX wants to merge 1 commit intotuupola:2.xfrom
MinhThienDX:2.x
Conversation
Fix bug when call split() on number
|
Instead of calling data("chained") and casting to String, per the jquery docs, we could call attr("data-chained") instead, and instead of coercing strings into numbers, the String type will be preserved. I've done that on my own branch and it works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug when call split() on number
Similar to this PR #74 but he changed the minified version