Skip to content
This repository was archived by the owner on Feb 11, 2026. It is now read-only.

Fix to set height with box padding#2

Closed
hissy wants to merge 1 commit intourin:masterfrom
hissy:fix-column-height
Closed

Fix to set height with box padding#2
hissy wants to merge 1 commit intourin:masterfrom
hissy:fix-column-height

Conversation

@hissy
Copy link

@hissy hissy commented Feb 12, 2014

パディングが無視されてしまうので

@urin
Copy link
Owner

urin commented Feb 12, 2014

ありがとうございます。非常に良い提言です。
box-sizing次第でouterHeightを使うかheightを使うか判定するようにしたいと思います。
すぐにアップデートします。

@hissy
Copy link
Author

hissy commented Feb 12, 2014

👍
ではこのPRは閉じますか?

@urin
Copy link
Owner

urin commented Feb 12, 2014

はい、閉じましょう。次のバージョンを待って下さい。
恐らく数日以内にリリースしますので。

@urin urin closed this Feb 12, 2014
@hissy hissy deleted the fix-column-height branch February 12, 2014 09:14
@hissy
Copy link
Author

hissy commented Feb 12, 2014

了解しました!

@hissy hissy restored the fix-column-height branch February 12, 2014 09:15
@hissy hissy deleted the fix-column-height branch February 12, 2014 09:17
urin added a commit that referenced this pull request Feb 12, 2014
…lculate and apply the maximum height. This modification is inspired by the issue #2.
@urin
Copy link
Owner

urin commented Feb 12, 2014

リリースしました 1.0.0

@hissy
Copy link
Author

hissy commented Feb 12, 2014

助かりました!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants