Disable config file loading in experimental vite-node compiler#1238
Merged
Disable config file loading in experimental vite-node compiler#1238
vite-node compiler#1238Conversation
🦋 Changeset detectedLatest commit: 60ee030 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
markdalgleish
approved these changes
Nov 20, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm attempting to get a
vite-plugin-nextgoing using the experimentalvite-nodecompiler, but ran into a bug when testing it in an external vite project (not the fixture).Despite the compiler creating a vite server programmatically using inline config, vite will still resolve and merge in a
vite.config.tsfile if it finds one. This causes thevite-nodevite server to end up with a copy of the VE vite plugin, which then tries to spin up another compiler, which tries then finds and merges the vite config, looping infinitely.Setting
configFile: falsedisables this config resolution behaviour. I can't think of a reason why we'd want to implicitly merge the user's vite config into thevite-nodecompiler's config, so this seems like a sensible change to me. The vite fixture config already sets this, so I didn't pick up the bug until I tried the plugin in a separate project.