Default emitCssInSsr if Remix plugin is present#1239
Merged
markdalgleish merged 1 commit intomasterfrom Nov 20, 2023
Merged
Conversation
🦋 Changeset detectedLatest commit: 688727a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1 task
mrm007
approved these changes
Nov 20, 2023
Merged
This was referenced Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag needed to be enabled in the Remix Vite plugin test suite in order for it to pass when using VE, so this PR adds Remix to the ever growing list of frameworks that need this feature enabled. This seems to be a sign that this should maybe be the default, but since that's likely to be considered a breaking change, it makes sense that this could go through as a non-breaking fix in the meantime.