Skip to content

Add esbuild-plugin#14

Merged
mattcompiles merged 21 commits intomasterfrom
esbuild
Apr 5, 2021
Merged

Add esbuild-plugin#14
mattcompiles merged 21 commits intomasterfrom
esbuild

Conversation

@mattcompiles
Copy link
Contributor

Current limitations:

  • No automatic readable class names in dev
  • The projectRoot plugin option must be set to get deterministic class name hashes between build systems

If projectRoot isn't set, fileScope will fallback to absolute paths. This is fine when building locally, but causes hash differences across different machines which would break caching.

@mattcompiles mattcompiles requested a review from a team as a code owner April 1, 2021 12:23
Co-authored-by: Mokshit Jain <mokshitjain2006@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Apr 2, 2021

⚠️ No Changeset found

Latest commit: a125f4c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@markdalgleish
Copy link
Contributor

Is this missing a changeset? Or are you planning to publish in a follow-up PR?

Co-authored-by: Mark Dalgleish <mark.john.dalgleish@gmail.com>
@mattcompiles
Copy link
Contributor Author

Packages are auto published if they haven't been published before. So you don't need a changeset for the first release.

};
}

const stringifyExports = (value: any) =>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More just marking this for future conversation, but this makes me think it might be good to have a more first-class integration API so stuff like this is handled for you.

Copy link
Contributor

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments, but nothing to hold up an approval. This is super exciting 🔥

@mattcompiles mattcompiles merged commit 2c46c8b into master Apr 5, 2021
@mattcompiles mattcompiles deleted the esbuild branch April 5, 2021 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants