Skip to content

Merge build options from viteConfig in compiler#1562

Closed
ngbrown wants to merge 2 commits intovanilla-extract-css:masterfrom
ngbrown:patch-1
Closed

Merge build options from viteConfig in compiler#1562
ngbrown wants to merge 2 commits intovanilla-extract-css:masterfrom
ngbrown:patch-1

Conversation

@ngbrown
Copy link

@ngbrown ngbrown commented Mar 23, 2025

I was trying to update Remix's use of @vanilla-extract/integration (which is still at v6) and came across how the new compiler package now inlines small files into the resulting CSS. These dataurl strings broke the Remix integration tests, so I figured it was better to match the prior behavior.

To match the prior behavior, I need to pass the option viteConfig.build.assetsInlineLimit: 0 into the compiler, but the build options were being ignored because the compiler is setting one of them.

So this patch is the minimum to get the option passed. I see that there have been earlier efforts to do a deep merge on the options (at least for the Vite plugin), but this is more narrow and is for the compiler.

@changeset-bot
Copy link

changeset-bot bot commented Mar 23, 2025

🦋 Changeset detected

Latest commit: 2903b3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@vanilla-extract/compiler Patch
@vanilla-extract/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis
Copy link
Contributor

askoufis commented Dec 7, 2025

With remix becoming react router, the upstream issue isn't really that relevant anymore, but this incidentally also fixes #1551. In #1665 I opted not to forward all the build properties as it felt a bit risky, so instead only assetsInlineLimit is propagated.

@askoufis
Copy link
Contributor

@ngbrown The fix in #1665 was released in @vanilla-extract/compiler@0.3.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants