Skip to content

Commit 3cee4bb

Browse files
ashishkumar468misaochan
authored andcommitted
Feature/bug fix#1793 (commons-app#1802)
* bug fix, locales not showing up in the spinner in ShareActivity [issue commons-app#1793] * removed extra padding from the languages edit text in the spinner * reduced weight percentage of spinner to 30% and increased that of the descriptions in row_item_descriptions to 70%
1 parent 61888f7 commit 3cee4bb

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

app/src/main/res/layout/row_item_description.xml

+3
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,17 @@
33
xmlns:android="http://schemas.android.com/apk/res/android"
44
android:layout_width="match_parent"
55
android:layout_height="wrap_content"
6+
xmlns:tools="http://schemas.android.com/tools"
67
android:orientation="horizontal"
78
android:weightSum="10">
89

910
<android.support.v7.widget.AppCompatSpinner
1011
android:id="@+id/spinner_description_languages"
1112
android:layout_width="0dp"
1213
android:layout_height="wrap_content"
14+
android:layout_gravity="center_vertical"
1315
android:layout_weight="3"
16+
tools:listitem="@layout/row_item_languages_spinner"
1417
android:spinnerMode="dialog"></android.support.v7.widget.AppCompatSpinner>
1518

1619
<android.support.design.widget.TextInputLayout

app/src/main/res/layout/row_item_languages_spinner.xml

+7-4
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,23 @@
22
<LinearLayout
33
xmlns:android="http://schemas.android.com/apk/res/android"
44
xmlns:tools="http://schemas.android.com/tools"
5+
android:id="@+id/ll_container_description_language"
56
android:layout_width="match_parent"
67
android:layout_height="wrap_content"
7-
android:padding="10dp"
8-
android:id="@+id/ll_container_description_language"
98
android:orientation="vertical">
109
<TextView
1110
android:id="@+id/tv_language"
11+
style="@style/Base.TextAppearance.AppCompat.Widget.TextView.SpinnerItem"
1212
android:layout_width="match_parent"
1313
android:layout_height="wrap_content"
14-
android:padding="4dp"
14+
android:paddingTop="10dp"
15+
android:paddingBottom="10dp"
16+
android:paddingLeft="4dp"
17+
android:paddingRight="4dp"
1518
android:imeOptions="flagNoExtractUi"
1619
android:maxLines="1"
17-
style="@style/Base.TextAppearance.AppCompat.Widget.TextView.SpinnerItem"
1820
android:singleLine="true"
21+
android:textAlignment="center"
1922
tools:text="en"
2023
/>
2124

0 commit comments

Comments
 (0)