Feature/bug fix#1793 #1802
Feature/bug fix#1793 #1802
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1802 +/- ##
======================================
Coverage 3.62% 3.62%
======================================
Files 192 192
Lines 9809 9809
Branches 863 863
======================================
Hits 356 356
Misses 9428 9428
Partials 25 25Continue to review full report at Codecov.
|
|
Looks good to me, happy to merge after tests succeed (please test with a small screen size emulator as well, preferably a Nexus S or similar). :) |
|
@misaochan I have already tested on Nexus S (The attached screenshot is from the same), as well as on samsung s device. Seems to be working fine. |
|
Thanks, I missed that note on your screenshot! Btw, is there a reason why there is so much padding between the text and the dropdown arrow on the right? This feature is still usable in its current state, but was wondering about that. The dropdown menu takes up half of the screen width on small screens. |
|
Actually, I have used the default spinner edit text layout which has the default padding. Let me see if I can figure out a way to somehow reduce the padding |
…commons into feature/bug_fix#1793
… descriptions in row_item_descriptions to 70%
|
@misaochan I believe the last commit will meet your requirements |
|
Thanks @ashishkumar0207 ! |
* bug fix, locales not showing up in the spinner in ShareActivity [issue commons-app#1793] * removed extra padding from the languages edit text in the spinner * reduced weight percentage of spinner to 30% and increased that of the descriptions in row_item_descriptions to 70%
Title (required)
Improve description language selector in ShareActivity
Fixes #{1793 and title (Improve description language selector in ShareActivity
) }
Description (required)
The spinner items in the ShareActivity were not showing up in certain devices.
{Describe the changes made and why they were made.}
Changed the ration of the spinner to the recycler view for description from 3:7 to 4:6
Tests performed (required)
Tested on {24 & Nexus s emulator}, with {build variant, e.g. betaD
ebug}.
Screenshots showing what changed (optional)
{Only for user interface changes, otherwise remove this section. See how to take a screenshot}
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.