Skip to content

Commit b176515

Browse files
Deskanamisaochan
authored andcommitted
Remove unnecessary Integer.toString() calls (commons-app#2959)
In cases where an integer is directly concatenated onto a string, toString() is not needed because it is called implicitly; this patch removes the calls to improve code readability.
1 parent 877c669 commit b176515

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

app/src/main/java/fr/free/nrw/commons/achievements/AchievementsActivity.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -356,7 +356,7 @@ private void inflateAchievements(Achievements achievements) {
356356
(achievements.getUniqueUsedImages() + "/" + levelInfo.getMaxUniqueImages());
357357
imagesFeatured.setText(String.valueOf(achievements.getFeaturedImages()));
358358
String levelUpInfoString = getString(R.string.level);
359-
levelUpInfoString += " " + Integer.toString(levelInfo.getLevelNumber());
359+
levelUpInfoString += " " + levelInfo.getLevelNumber();
360360
levelNumber.setText(levelUpInfoString);
361361
imageView.setImageDrawable(VectorDrawableCompat.create(getResources(), R.drawable.badge,
362362
new ContextThemeWrapper(this, levelInfo.getLevelStyle()).getTheme()));

app/src/main/java/fr/free/nrw/commons/upload/UploadActivity.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -516,10 +516,10 @@ public void configurePrevButton(Boolean saveForPrevImage){
516516
int descCount = directKvStore.getInt(name + "descCount");
517517
for (int i = 0; i < descCount; i++) {
518518
Description description= new Description();
519-
String desc = directKvStore.getString(name + "description_<"+Integer.toString(i)+">");
519+
String desc = directKvStore.getString(name + "description_<" + i + ">");
520520
description.setDescriptionText(desc);
521521
finalDesc.add(description);
522-
int position = directKvStore.getInt(name + "spinnerPosition_<"+Integer.toString(i)+">");
522+
int position = directKvStore.getInt(name + "spinnerPosition_<" + i + ">");
523523
description.setSelectedLanguageIndex(position);
524524
}
525525
prevTitleDecs.setOnTouchListener((v, event) -> {
@@ -744,8 +744,8 @@ public void savePrevTitleDesc(String name){
744744
int n = descriptionsAdapter.getItemCount() - 1;
745745
directKvStore.putInt(name + "descCount", n);
746746
for (int i = 0; i < n; i++) {
747-
directKvStore.putString(name + "description_<"+Integer.toString(i)+">", descriptionsAdapter.getDescriptions().get(i).getDescriptionText());
748-
directKvStore.putInt(name + "spinnerPosition_<" + Integer.toString(i) + ">", descriptionsAdapter.getDescriptions().get(i).getSelectedLanguageIndex());
747+
directKvStore.putString(name + "description_<" + i + ">", descriptionsAdapter.getDescriptions().get(i).getDescriptionText());
748+
directKvStore.putInt(name + "spinnerPosition_<" + i + ">", descriptionsAdapter.getDescriptions().get(i).getSelectedLanguageIndex());
749749
}
750750
}
751751
}

0 commit comments

Comments
 (0)