Optional Attribute #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! this seems like an important feature! But I will move the code to jQueryFormUtils.validateInput, the only function that is supposed to know how to validate a certain input. |
|
That makes sense. I'm glad it was useful! |
|
The name of the attribute is now renamed. We try to stay with the namespace data-validation, the new name is therefor data-validation-optional. One could argue that this is a bit long name to write but staying to a single namespace is favored in this case... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you need to say "this is an optional field but if there's something there I need it validated."
I'm not sure if this fits in perfectly, but it looks like this:
Maybe there could be a setting which says "assume required" (default) or "assume optional" which could then be overridden by a data-required="true/false".
What do you think?