Pass formQuery to jQuery instead of spliting it #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows passing DOM nodes (anything jQuery understand).
victorjonsson
added a commit
that referenced
this pull request
Jul 23, 2014
Pass formQuery to jQuery instead of spliting it
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed this change as I'm initializing the nodes dynamically and I really do not want to give them each a unique ID. I was a bit astonished that one cannot simply pass DOM nodes directly as argument for "form".
I found that the culprit was the explicit split on the passed variable, which IMO does not make sense, since using it via jQuery.each should result in the exact same behaviour as before (IMHO).
Best regards
Marcel Greter