server validation, stop removal of attr holding err msg #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if server side validation does not return a specific message, don't remove the element attribute that holds a validation error message. this allows the failure of the server side validation to use the err msg specified in the element's attr. the specification of error messages may be in the domain / control of the web designer / form builder, and not the server side programmer. furthermore, the data validation error message attr of the active element may need to be used by other validation routines, and if attr is removed, other validation err msgs would appear blank.
same as previous edit, don't remove attribute first time field is validated at the server, server returns null message so newer code using inline err msg. works good. then when editing input element value, on keyup event, attr holding the inline err msg is removed, and when server returns validation error with no message, the err displayed to user is blank, since the inline err msg has been removed previously.
victorjonsson
added a commit
that referenced
this pull request
Dec 28, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if server side validation does not return a specific message, don't remove the element attribute that holds a validation error message.
this allows the failure of the server side validation to use the err msg specified in the element's attr.
the specification of error messages may be in the domain / control of the web designer / form builder, and not the server side programmer.
furthermore, the data validation error message attr of the active element may need to be used by other validation routines, and if attr is removed, other validation err msgs would appear blank.