Issue315 - let data-validation-optional work on input type=number #379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add tests for input type=number * Change spacing for better legibility * Remove statement in core-validators which always evaluated to true * Remove unnecessary if-else branch checking for data-validation-optional If a value is entered into an input type=number that the browser cannot parse, the browser sets the value of it to an empty string. This means that we can't tell the difference between a browser-unparsable input and an empty input.
|
Great! The input, of type number, is a tricky one... |
victorjonsson
added a commit
that referenced
this pull request
Feb 5, 2016
Issue315 - let data-validation-optional work on input type=number
|
Cool. |
|
Take your pick. I'm currently not working on any of them. I'm available for discussion if there's something you feel we need to elaborate on, just post a message in the issue you'll be working with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.