fix for issue #323 #382
Merged
fix for issue #323 #382
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…before validating them -Add test for numberFormat sanitizer with number; add tests to ensure that double sanitizing has no impact on input value -Bug found involving escape sanitizer (see issue victorjonsson#381) (The failing test has been commented out.)
The current 'test' task unminifies all the currently minified files, creating false changes. Ideally there could be a dev task that does not affect minified files at all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also what do you think about having a Grunt dev task which would not minify any files? Do you want a version bump after every commit? I'm thinking of how to make the build process work better with git so that it's easier to make clean commits without too many extra files being touched.